[PM-17113] Fix system authentication setup #12907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
mzieniukbw
approved these changes
Jan 16, 2025
quexten
added a commit
that referenced
this pull request
Jan 16, 2025
* Fix system authentication setup * Fix biometric status * Remove debug log * Fix tests (cherry picked from commit 97ee050)
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12907 +/- ##
=======================================
Coverage 34.44% 34.45%
=======================================
Files 2974 2974
Lines 90666 90667 +1
Branches 16989 16989
=======================================
+ Hits 31233 31240 +7
+ Misses 56967 56961 -6
Partials 2466 2466 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17113
📔 Objective
Fixes the logic for determining when biometrics needs to be set-up. On linux, biometrics is "HardwareUnavailable" if no password service is available to store the key. We cannot detect actual hardware availability, and allow system password fallback anyways.
If the password service is available, only then do we check the status of the biometrics policy - whether it was set up - and give back the appropriate status.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes